Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
rosstimothy
reviewed
Jul 29, 2024
atburke
added
the
no-changelog
smallinsky
approved these changes
Jul 30, 2024
atburke
force-pushed
the
atburke/static-user-proto
branch
from
fa529da to
a134b2d
Compare
rosstimothy
reviewed
Jul 30, 2024
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Looks like something got messed up after your other PR with the proto change was merged as they are included here as well.
rosstimothy
reviewed
Jul 30, 2024
atburke
force-pushed
the
atburke/static-user-service
branch
from
986b994 to
83688e5
Compare
Contributor
Author
I think I forgot to run |
rosstimothy
approved these changes
Jul 31, 2024
| assert: require.Error, | ||
| }, | ||
| { | ||
| name: "invalid node labels", |
Contributor
There was a problem hiding this comment.
A label of *:* should be allowed right? Can we add a test case to cover it?
This change adds a local service for the static host user resource.
atburke
force-pushed
the
atburke/static-user-service
branch
from
05bea55 to
7e38e84
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
atburke
added a commit
that referenced
this pull request
Sep 10, 2024
This change adds a local service for the static host user resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a local service for the static host user resource (RFD 175).
Part of #42712.