Conversation
github-actions
Bot
added
machine-id
size/sm
tsh
nklaassen
added
the
no-changelog
Contributor
Author
|
friendly ping @greedy52 @timothyb89 @flyinghermit |
flyinghermit
approved these changes
Aug 6, 2024
Contributor
flyinghermit
left a comment
flyinghermit
left a comment
There was a problem hiding this comment.
I only reviewed code level changes and those changes LGTM.
Please also get a review from database access team.
nklaassen
force-pushed
the
nklaassen/renames
branch
from
05e0b70 to
05285de
Compare
nklaassen
force-pushed
the
nklaassen/split-db-keys
branch
from
326dbba to
f43a861
Compare
greedy52
approved these changes
Aug 6, 2024
Contributor
There was a problem hiding this comment.
Overall LGTM. Thanks!
Several comments:
- Looks like
lib/teletermdoes not need an update? (as recently we changed it to use TLS cert in memory instead of paths ) - The team will test out all databases during release testing.
- Since some paths changed, this would be a breaking change for existing scripts that assumes the key/cert path. Might worth a small note on the release change log?
| args := append([]string{ | ||
| // default --db-user and --db-name are selected from roles. | ||
| "db", "login", | ||
| "db", "login", "--insecure", |
Contributor
Author
There was a problem hiding this comment.
I introduced a Ping that hits the proxy and requires --insecure flag for this test, mustLogin already used for the initial login uses --insecure as well
nklaassen
removed
the
no-changelog
Contributor
Author
Yep, looks like it's fine.
Thanks! I'm counting on it
I'm planning to add a changelog entry for the whole "configurable algorithm suites" feature later, but these seems like a good point to mention the changed file paths, added a CL entry to the PR description |
nklaassen
force-pushed
the
nklaassen/renames
branch
from
05285de to
ce700b7
Compare
nklaassen
force-pushed
the
nklaassen/split-db-keys
branch
from
f43a861 to
a57db58
Compare
nklaassen
force-pushed
the
nklaassen/split-db-keys
branch
from
a57db58 to
951fe64
Compare
timothyb89
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the implementation of RFD 136.
The main change here is that
tshnow uses a unique private key every time it gets a new db cert issued. This new key will use a signature algorithm according to the cluster's currently configuredsignature_algorithm_suite.Changelog: Changed the certificate and private key file paths for application, database, and Kubernetes access.