fix some events not getting converted to AuditEvents correctly#44632
Merged
capnspacehook merged 2 commits intomasterfrom Aug 5, 2024
Merged
fix some events not getting converted to AuditEvents correctly#44632capnspacehook merged 2 commits intomasterfrom
capnspacehook merged 2 commits intomasterfrom
Conversation
capnspacehook
added
backport/branch/v14
no-changelog
github-actions
Bot
added
audit-log
marcoandredinis
approved these changes
Jul 25, 2024
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Can we please add some test coverage?
zmb3
approved these changes
Jul 25, 2024
public-teleport-github-review-bot
Bot
removed request for
gabrielcorado and
kimlisa
Contributor
Author
|
I added a test that will check that all events can be converted correctly, should hopefully catch similar future errors when new event types are added. @marcoandredinis @zmb3 the test look good? |
capnspacehook
force-pushed
the
capnspacehook/fix-event-dynamic-conversion
branch
from
8b79d92 to
16f77fb
Compare
|
@capnspacehook See the table below for backport results.
|
This was referenced Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.