Fix formatting of mockServiceWorker.js#44620
Merged
Conversation
ravicious
added
the
no-changelog
ravicious
force-pushed
the
r7s/msw-formatting
branch
from
1bf5844 to
d03da9e
Compare
espadolini
approved these changes
Jul 25, 2024
ryanclark
approved these changes
Jul 25, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44041 ended up merging a version of mockServiceWorker.js that was formatted by our prettier. This means that any time someone installs msw v2 for the first time, the postinstall script pulls down a fresh copy of that file which of course isn't formatted with our prettier config. As such, they end up with some changes on their current branch.
This PR fixes that by re-running
pnpm msw init web/.storybook/publicand saving the "unformatted" file.