Conversation
Contributor
|
I think in order for #44410 to be closed we need to address tsh app login as well. It is pulling AWS ARN information from the root certificate when logging into an app in a leaf cluster. |
rosstimothy
approved these changes
Jul 25, 2024
greedy52
approved these changes
Jul 25, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from espadolini
This was referenced Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/gravitational/customer-sensitive-requests/issues/303 and #44410.
This change follows the same solution used by SSH logins (introduced by #39579), where allowed logins (AWS ARN roles) are returned by the auth server (through enriched resources) instead of by the API.
Given this change, we must also keep the root AWS role ARNs on the remote access info. Otherwise, the enriched resource will only contain the leaf cluster roles.
As a result, the roles shown in the Web UI will include AWS role ARNs from the user, root cluster roles, and leaf cluster roles.
changelog: Correctly display available allowed logins of leaf AWS Console Apps in the root cluster Web UI