Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify leaf cluster when generating kubeconfig via tctl auth sign #4446

Merged
merged 7 commits into from
Oct 6, 2020

Conversation

cnelson
Copy link
Contributor

@cnelson cnelson commented Oct 3, 2020

Extend #3614 to add support for generating kubeconfigs for leaf clusters via tctl auth sign.

Fixes #4405

@gravitational-jenkins
Copy link

Can one of the admins verify this patch?

@awly
Copy link
Contributor

awly commented Oct 5, 2020

ok to test

@cnelson cnelson force-pushed the feat/auth-sign-k8s-leaf branch from 1533743 to b5e4196 Compare October 5, 2020 22:59
@cnelson
Copy link
Contributor Author

cnelson commented Oct 5, 2020

Rebased onto master to deal with conflict

Copy link
Contributor

@awly awly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retest this please

@awly
Copy link
Contributor

awly commented Oct 5, 2020

retest this please

@awly
Copy link
Contributor

awly commented Oct 6, 2020

retest this please

@awly awly merged commit 7719444 into gravitational:master Oct 6, 2020
@webvictim
Copy link
Contributor

@cnelson Thanks very much for the PR!

@cnelson
Copy link
Contributor Author

cnelson commented Oct 6, 2020

Thanks for the the quick review / merge! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long lived kubeconfig for trusted clusters?
4 participants