[v14] Prevent auth from starting when an incompatible major upgrade is detected#44362
Merged
vapopov merged 1 commit intobranch/v14from Jul 18, 2024
Merged
[v14] Prevent auth from starting when an incompatible major upgrade is detected#44362vapopov merged 1 commit intobranch/v14from
vapopov merged 1 commit intobranch/v14from
Conversation
vapopov
added
backport
no-changelog
github-actions
Bot
requested review from
bl-nero,
fspmarshall,
r0mant,
rosstimothy and
zmb3
r0mant
approved these changes
Jul 17, 2024
fspmarshall
approved these changes
Jul 17, 2024
public-teleport-github-review-bot
Bot
removed request for
bl-nero,
rosstimothy and
zmb3
…cted (#43520) * Teleport auth should refuse to start when jumping major versions (#41782) * linter fixes * code review changes: - replaced to use process storage and state itme - regexp replaced with semver - additional check for v18 for empty version record in storage * code review changes: - add integration test - store latest version in separate key * code review changes: - table tests - error message * code review changes: - minor changes * code review changes: - reuse context for write operation * code review changes: - simplify integration test - add downgrade check - minor changes * code review changes: - move logic to the auth init * code review changes: - add development env to skip version check - init the process storage if it is not set * code review changes: - add interface for local process storage - use semver in storage instead * change interface to version storage * add fake version storage for other tests
vapopov
force-pushed
the
vapopov/major-version-check-v14
branch
from
2ae529d to
ba8ee54
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #43520 to branch/v14