Add Terraform Provider native MachineID support#44306
Merged
Conversation
hugoShaka
force-pushed
the
hugo/cleanup-terraform-credential-handling
branch
2 times, most recently
from
645fc09 to
cbdd0d8
Compare
Base automatically changed from
hugo/cleanup-terraform-credential-handling
to
master
July 25, 2024 21:54
hugoShaka
force-pushed
the
hugo/terraform-native-machineid-2
branch
from
4ffd8fb to
da696eb
Compare
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
🤖 Vercel preview here: https://docs-i0vmez7sb-goteleport.vercel.app/docs/ver/preview |
strideynet
approved these changes
Jul 26, 2024
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Ship it ! Can't wait to update the Spacelift docs etc not to require the custom runner image.
marcoandredinis
approved these changes
Jul 26, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from tigrato
tigrato
approved these changes
Jul 26, 2024
Contributor
|
🤖 Vercel preview here: https://docs-hnws666hn-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
hugoShaka
added a commit
that referenced
this pull request
Jul 26, 2024
* Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint
hugoShaka
added a commit
that referenced
this pull request
Aug 1, 2024
* Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint
hugoShaka
added a commit
that referenced
this pull request
Aug 2, 2024
* Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint
hugoShaka
added a commit
that referenced
this pull request
Aug 6, 2024
* Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint
marcoandredinis
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
) * Introduce the `tctl terraform env` command (#43664) * Introduce the `tctl terrafor env` command * fix tests * address marco's feedback + use correct b64 lib * add license * add created-by label as specified in the RFD * Update tool/tctl/common/terraform_command.go Co-authored-by: Roman Tkachenko <roman@goteleport.com> * Apply suggestions from code review Co-authored-by: Roman Tkachenko <roman@goteleport.com> * Have telpeort create the Terraform default role * rename use-existing-role -> role, and stop hijacking identity.SSHCACertBytes * Make the terraform provider role a real preset, rename to 'terraform-provider' * lint * Fix tbot's invocation after rebase --------- Co-authored-by: Roman Tkachenko <roman@goteleport.com> * Refactor Terraform credential loading (#44037) * Refactor Terraform credential loading * Warn about expiry * kip expired credentials * fixup! kip expired credentials * Use constants everywhere + add godocs * fixup! Use constants everywhere + add godocs * Address marco's feedback * fixup! Address marco's feedback * tidy go mod * lint * re-render TF docs * Update v16 version in error message * Add Terraform Provider native MachineID support (#44306) * Add Terraform Provider native MachineID support * Reject 'token' join method * lint: fix imports * re-render TF docs * fix tests + add license * lint * tidy go mod * use v16 client.Expiry() function --------- Co-authored-by: Roman Tkachenko <roman@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the second half of RFD 173: adds support for native MachineID terraform joining.
Changelog: Add native MachineID support in the TF provider. The TF provide can now use bot join tokens to connect to Teleport.