Add cluster_name to proxy kubernetes config #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
awly
force-pushed
the
andrew/k8s-cluster-name-config
branch
4 times, most recently
from
6f85e20 to
bd89569
Compare
webvictim
reviewed
Sep 25, 2020
|
LGTM (once the conflicts are fixed) - I'll leave it for the others as it's core functionality though. |
awly
force-pushed
the
andrew/k8s-cluster-name-config
branch
from
f13afb7 to
88e2838
Compare
|
retest this please |
Cluster name from this field plug all clusters from kubeconfig are stored on the auth server via heartbeats. This info will later be used to route k8s requests back to proxies. Updates #3952
awly
force-pushed
the
andrew/k8s-cluster-name-config
branch
from
88e2838 to
8d65f6b
Compare
russjones
reviewed
Sep 29, 2020
Co-authored-by: Gus Luxton <[email protected]>
awly
force-pushed
the
andrew/k8s-cluster-name-config
branch
from
8d65f6b to
cbef815
Compare
russjones
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster name from this field plug all clusters from kubeconfig are
stored on the auth server via heartbeats.
This info will later be used to route k8s requests back to proxies.
Updates #3952