Machine ID: Render kubernetes template without exec plugin when using non-directory destination#43401
Merged
strideynet merged 6 commits intomasterfrom Jun 25, 2024
Conversation
Contributor
Author
|
CC @webvictim |
webvictim
reviewed
Jun 24, 2024
webvictim
approved these changes
Jun 24, 2024
AntonAM
approved these changes
Jun 24, 2024
espadolini
approved these changes
Jun 25, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
tigrato
approved these changes
Jun 25, 2024
strideynet
deleted the
strideynet/output-kubernetes-template-without-exec-plugin
branch
|
@strideynet See the table below for backport results.
|
This was referenced Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few customers have run into "must be a directory in exec plugin mode" - whilst there's a configurable option for this, it makes more sense for
tbotto just default to enabling this setting to reduce friction. This should reduce support load.changelog: Machine ID defaults to disabling the use of the Kubernetes exec plugin when writing a Kubeconfig to a directory destination. This removes the need to manually configure
disable_exec_plugin.