consolidate (un)marshalling of keys to/from PEM format#43260
Merged
consolidate (un)marshalling of keys to/from PEM format#43260
Conversation
nklaassen
added
no-changelog
nklaassen
force-pushed
the
nklaassen/consolidate-key-marshal
branch
2 times, most recently
from
f9f72d6 to
0cb7701
Compare
zmb3
approved these changes
Jun 21, 2024
timothyb89
approved these changes
Jun 21, 2024
Contributor
timothyb89
left a comment
timothyb89
left a comment
There was a problem hiding this comment.
Looks fine to me, aside from the missing license header
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
This commit consolidates various functions we have for marshalling private and public keys to and from the PEM format, mostly by replacing functions from lib/utils and lib/tlsca with equivalents in api/utils/keys. The new functions also support ECDSA and Ed25519 keys, which is necessary for the implementation of RFD136.
nklaassen
force-pushed
the
nklaassen/consolidate-key-marshal
branch
from
2f67100 to
d9a94f7
Compare
|
@nklaassen See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit consolidates various functions we have for marshalling private and public keys to and from PEM-encoded DER, mostly by replacing functions from lib/utils and lib/tlsca with equivalents in api/utils/keys.
The new functions also support ECDSA and Ed25519 keys, which is necessary for the implementation of RFD 136.
This doesn't make any functional changes, except that new key algorithms will be supported when we start using them.