Add check to AMR watcher to handle subject removing requests#42171
Merged
EdwardDowling merged 6 commits intomasterfrom May 30, 2024
Merged
Add check to AMR watcher to handle subject removing requests#42171EdwardDowling merged 6 commits intomasterfrom
EdwardDowling merged 6 commits intomasterfrom
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
kimlisa
approved these changes
May 30, 2024
r0mant
approved these changes
May 30, 2024
public-teleport-github-review-bot
Bot
removed request for
hugoShaka and
marcoandredinis
EdwardDowling
deleted the
edwarddowling/access-monitoring-rule-watcher-filter
branch
|
@EdwardDowling See the table below for backport results.
|
This was referenced May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 3132
Prevents watcher that updates the cache of rules for the plugins from discarding updates that remove KindAccessRequest from the subjects.
changelog: Fix bug where the plugins AMR cache is not updated in the event Access requests are removed from the subject of an existing rule