[v15] prevent session id reuse#42164
Merged
capnspacehook merged 1 commit intobranch/v15from Jul 9, 2024
Merged
Conversation
github-actions
bot
requested review from
espadolini,
marcoandredinis and
rosstimothy
r0mant
reviewed
May 30, 2024
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Let's hold off this v15 backport until we're done with v16 test plan.
espadolini
approved these changes
May 30, 2024
Contributor
|
The v16 backport only just landed, if most folks use alpha.2 to perform the test plan they won't be exercising any of this code to find problems though. |
Collaborator
|
Yes, let's cut another release. I'll kick it off now. |
Contributor
|
Is this good to land in v15 now? |
Contributor
Author
|
It should be, no issues related to it were found in the test plan |
capnspacehook
force-pushed
the
capnspacehook/backport/v15/42123
branch
from
39c2e95 to
6b9686e
Compare
marcoandredinis
approved these changes
Jul 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
* prevent SSH session id reuse If a user sets `TELEPORT_SESSION` to a session ID that isn't running, the sent session ID is ignored and a new one is used to prevent the user controlling the value. When parsing a session ID the parsed result is used to ensure all session IDs will have the same format. `CreateSessionTracker` is updated to create instead of upsert to ensure `SessionTracker` resources cannot be overwritten by accident. Clients often need to know the current session ID, and before when they were in control of it that wasn't an issue. To fix this servers will send the current session ID in a SSH channel request on the channel the SSH session was created on. This should be fully backwards compatible, as when an unknown SSH request type is received clients will just ignore it/reply with false. * add test for wrappedSSHConn
capnspacehook
force-pushed
the
capnspacehook/backport/v15/42123
branch
from
6b9686e to
afaa063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42123.
changelog: Fixed session recordings getting overwritten or not uploaded