[v16] Fix azure join when filtering by resource group#42142
Merged
marcoandredinis merged 2 commits intobranch/v16from May 31, 2024
Merged
[v16] Fix azure join when filtering by resource group#42142marcoandredinis merged 2 commits intobranch/v16from
marcoandredinis merged 2 commits intobranch/v16from
Conversation
greedy52
approved these changes
May 29, 2024
ravicious
approved these changes
May 29, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Azure Resource Groups are not case sensitive. The API usually returns them in all caps. When deciding whether to accept a new node using the azure join method, we should ignore the case of the resource groups.
marcoandredinis
force-pushed
the
bot/backport-42128-branch/v16
branch
from
78f3331 to
c438b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #42128 to branch/v16
changelog: Fix Azure join method when using Resource Groups in the allow section.