Skip to content

docs: document EKS Auto discovery self-bootstrap#42107

Merged
tigrato merged 7 commits intomasterfrom
tigrato/kube-auto-discovery-docs
May 30, 2024
Merged

docs: document EKS Auto discovery self-bootstrap#42107
tigrato merged 7 commits intomasterfrom
tigrato/kube-auto-discovery-docs

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented May 28, 2024

This PR documents EKS auto-discovery self bootstrap using AccessEntries to gain access to the cluster.

Docs for #41693

@tigrato tigrato added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 28, 2024
This PR documents EKS auto-discovery self bootstrap using AccessEntries
to gain access to the cluster.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato force-pushed the tigrato/kube-auto-discovery-docs branch from 4858965 to 260be7a Compare May 28, 2024 20:02
@tigrato tigrato marked this pull request as ready for review May 28, 2024 20:04
@github-actions github-actions Bot requested review from ptgott, r0mant, xinding33 and zmb3 May 28, 2024 20:04
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-g4vxyx1n7-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-cd0lnwx6g-goteleport.vercel.app/docs/ver/preview

Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
Co-authored-by: Steven Martin <steven@goteleport.com>
Co-authored-by: Steven Martin <steven@goteleport.com>
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-27dz0ayy5-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-osay5sr17-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-l5n0qmumw-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-mv7r3rurx-goteleport.vercel.app/docs/ver/preview

Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a partial review of everything besides the docs/pages/auto-discovery/kubernetes/aws.mdx guide.

Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
the Teleport Discovery Service. The monitoring process involves a label
matching mechanism to identify and manage the EKS clusters.

1. **Discovery and Label Matching**:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is a little difficult for me to read. Would it be possible to use subheadings in place of the numbered list items and regular body text instead of the bulleted list items? Since these are full sentences, I don't think bullets make them more readable.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? I tried to split them in operations that would make sense

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a suggestion!

Comment thread docs/pages/auto-discovery/kubernetes.mdx
@tigrato tigrato requested a review from ptgott May 29, 2024 22:18
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-f0xh41h0u-goteleport.vercel.app/docs/ver/preview

Comment thread docs/pages/auto-discovery/kubernetes.mdx Outdated
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-jsh95th3m-goteleport.vercel.app/docs/ver/preview

@tigrato tigrato added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit d86c25e May 30, 2024
@tigrato tigrato deleted the tigrato/kube-auto-discovery-docs branch May 30, 2024 21:35
@public-teleport-github-review-bot
Copy link
Copy Markdown

@tigrato See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants