Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v
in the path for uploaded FIPS artifacts which prevents uploads to S3 from working correctly.RUNTIME
for an RPM build that doesn't need it, which is confusing the RPM build script.make image
ormake -C e image-fips
, it's always been assumed that these commands are run by Jenkins, which has an external script that will set theVERSION
andGITTAG
variables. This isn't a safe or healthy assumption, so we're now being more explicit about passing the variables around when they're needed.FIPS=yes
when requesting that binaries are built, which we shouldn't assume exists. If we're running thebuild-binaries-fips
command, it needs to setFIPS=yes
itself.build-binaries
andbuild-binaries-fips
commands previously calledmake all
which doesn't add the web assets to Teleport binaries. They now callmake full
, which does add the web assets. This was an oversight on my part.make image
command is wrapped by another script that builds the binaries before it's invoked (andmake clean
was never previously run beforemake image
), it was just picking up those leftover binaries for the Docker image.Makefile
to make way for the introduction of Drone, this assumption for Jenkins didn't hold true any more. It's now explicit thatmake image
andmake -C e image-fips
need to build their own binaries beforehand.Fixes #4203