Skip to content

Desktop access: add option to send ctrl+alt+del#41449

Merged
zmb3 merged 1 commit intomasterfrom
zmb3/desktop-ctrl-alt-del
May 16, 2024
Merged

Desktop access: add option to send ctrl+alt+del#41449
zmb3 merged 1 commit intomasterfrom
zmb3/desktop-ctrl-alt-del

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented May 12, 2024

Closes #41448

Changelog: Add an option to send a Ctrl+Alt+Del sequence to remote desktops.

@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented May 12, 2024

Screenshot 2024-05-12 at 10 47 16 AM

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 requested a review from ibeckermayer May 12, 2024 19:35
@zmb3 zmb3 force-pushed the zmb3/desktop-ctrl-alt-del branch from f682508 to a848656 Compare May 13, 2024 15:21
Copy link
Copy Markdown
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks like a black square to me in light mode. It's also a little "bold" compared to the other icons in dark mode, maybe there's a way to invert the light/dark that could make it appear more inline with the others.
image

Comment thread web/packages/teleport/src/DesktopSession/useDesktopSession.tsx Outdated
@zmb3 zmb3 force-pushed the zmb3/desktop-ctrl-alt-del branch from a848656 to 13bdd2b Compare May 15, 2024 15:03
@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented May 15, 2024

@ibeckermayer the icon has been fixed, good catch

@zmb3 zmb3 force-pushed the zmb3/desktop-ctrl-alt-del branch from 13bdd2b to f3ffbb7 Compare May 15, 2024 15:13
@zmb3 zmb3 added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit 2cf0360 May 16, 2024
@zmb3 zmb3 deleted the zmb3/desktop-ctrl-alt-del branch May 16, 2024 13:50
@public-teleport-github-review-bot
Copy link
Copy Markdown

@zmb3 See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop Access: Add menu option to send ctrl+alt+del to remote server

4 participants