Fix integration filtering in AwsAccount selector#41329
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
justinas
added
the
no-changelog
marcoandredinis
approved these changes
May 10, 2024
ryanclark
approved these changes
May 13, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #40998 added a new integration kind (
azure-oidc), the selector for AWS integration to use in the Discover flow stopped working (would display an empty list, crash when user attempts to type in the name manually). This seems to be because the existing code maps unknown integration types toundefined(by an implicit return if the kind does not matchaws-oidc).This fixes this by filtering for only
aws-oidcas a separate step.