Web: Remove legacy app access support#41243
Merged
Conversation
kimlisa
added
the
no-changelog
zmb3
approved these changes
May 6, 2024
kimlisa
force-pushed
the
lisa/remove-legacy-app-access
branch
from
388b6b4 to
b8fd892
Compare
kimlisa
force-pushed
the
lisa/remove-legacy-app-access
branch
from
b8fd892 to
3dbf3ca
Compare
Contributor
Author
|
friendly ping @bl-nero @ryanclark |
bl-nero
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically reverts this commit: cc691d0
v16+https://github.com/gravitational/security-findings/issues/89I first tested dumper had issues with legacy app access (using the old AppLauncher.tsx component)
Then after removal of legacy, tested dumper access worked in chrome, brave, firefox
It said
DELETE IN 17.0, but the fix was introduced inv15.0.0, so i miscalculated initially.