[v14] Add server-side tpm joining implementation (#40512)#40875
Merged
strideynet merged 1 commit intobranch/v14from Apr 25, 2024
Merged
[v14] Add server-side tpm joining implementation (#40512)#40875strideynet merged 1 commit intobranch/v14from
tpm joining implementation (#40512)#40875strideynet merged 1 commit intobranch/v14from
Conversation
* Add clientside elements of TPM joining * Update lib/auth/register.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update api/client/joinservice.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update lib/auth/register.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Tidy up RegisterUsingTPMMethod method * Add default case * Rename CheckAndSetDefaults to validate * Add basic success test for JoinServiceClient_RegisterUsingTPMMethod * Add final touches to client joinservice test * Add license header to joinservice_test.go * Add server-side elements of TPM joining * Turn SAN extension code into helper func * Add `ok` check to provision token casting * Improve test name * Update lib/auth/join_tpm.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update lib/auth/join_tpm.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Unexported registerUsingTPMMethod * Refactor enterprise error * tidy up test * Update lib/tpm/validate.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update lib/auth/join_tpm.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update lib/auth/join_tpm_test.go Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Fix StripSANExtensionOIDs and add test * Improve joinserver.go, use simpler proto getter methods and use slog * Tidy up join_tpm_test.go * Tidy up joinserver_test * Add join failure audit event --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com>
tigrato
approved these changes
Apr 25, 2024
codingllama
approved these changes
Apr 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #40512
changelog: Introduced the tpm join method, which allows for secure joining in on-prem environments without the need for a shared secret.