Connector circuit breaker metrics#40729
Merged
espadolini merged 4 commits intomasterfrom Apr 22, 2024
Merged
Conversation
espadolini
changed the title
rosstimothy
reviewed
Apr 19, 2024
rosstimothy
approved these changes
Apr 19, 2024
avatus
approved these changes
Apr 20, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from GavinFrazar
zmb3
approved these changes
Apr 21, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@espadolini See the table below for backport results.
|
This was referenced Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
teleport_breaker_connector_executions_totalprom metric to count circuit breaker executions for the circuit breakers used by Teleport connectors, labeled by system role, circuit breaker state (standby,trippedandrecovering) and execution success (trueorfalse), and instruments the connectors to feed the metric.In addition, this adds additional logging for failed instance/bot joins to the cluster, which currently log a message before actually doing anything, and then don't log anything on error - which made a recent sev1 harder to diagnose than it should've been.
changelog: added a new Prometheus metric to track requests initiated by Teleport against the control plane API