[v15] Remove header manipulation after request has been completed, when proxying k8s requests.#40720
Merged
AntonAM merged 1 commit intobranch/v15from Apr 19, 2024
Merged
Conversation
It could lead to panic (concurrent map write and read) in case of request cancelation.
tigrato
approved these changes
Apr 19, 2024
rosstimothy
approved these changes
Apr 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from marcoandredinis
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #40718 to branch/v15
changelog: Fixed possible data race that could lead to concurrent map read and map write while proxying Kubernetes requests.