Skip to content

Add clientside elements of TPM joining#40647

Merged
strideynet merged 10 commits intomasterfrom
strideynet/tpm-joining-clientside
Apr 23, 2024
Merged

Add clientside elements of TPM joining#40647
strideynet merged 10 commits intomasterfrom
strideynet/tpm-joining-clientside

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

@strideynet strideynet commented Apr 18, 2024

Adds the client side of TPM joining, this makes more sense in the context of the follow on PR: #40512

As per RFD #38613
Followed on by #40512

@strideynet strideynet force-pushed the strideynet/tpm-joining-clientside branch from 99cf5e5 to 8071b7f Compare April 18, 2024 09:33
@strideynet strideynet requested a review from codingllama April 18, 2024 09:35
@strideynet strideynet added the no-changelog Indicates that a PR does not require a changelog entry label Apr 18, 2024
@strideynet strideynet marked this pull request as ready for review April 18, 2024 09:36
@github-actions github-actions Bot requested review from greedy52 and ravicious April 18, 2024 09:36
@strideynet strideynet requested review from lxea and tigrato and removed request for greedy52 and ravicious April 18, 2024 09:37
Comment thread api/client/joinservice.go Outdated
Comment thread api/client/joinservice.go
Comment thread api/client/joinservice.go Outdated
Comment thread api/client/joinservice.go Outdated
Comment thread api/client/joinservice.go Outdated
Comment thread lib/auth/register.go
Comment thread lib/auth/register.go Outdated
Comment thread lib/auth/register.go Outdated
Comment thread api/client/joinservice.go
Comment thread lib/auth/register.go
Comment thread api/types/provisioning.go Outdated
Comment thread lib/auth/register.go
Comment thread api/client/joinservice_test.go Outdated
Comment thread api/client/joinservice_test.go Outdated
Comment thread api/client/joinservice_test.go Outdated
@codingllama
Copy link
Copy Markdown
Contributor

Looks good, just a couple of minor comments in the tests.

@strideynet strideynet requested a review from codingllama April 22, 2024 11:26
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from lxea April 23, 2024 10:16
@strideynet strideynet added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 038bff1 Apr 23, 2024
@strideynet strideynet deleted the strideynet/tpm-joining-clientside branch April 23, 2024 11:36
@public-teleport-github-review-bot
Copy link
Copy Markdown

@strideynet See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

machine-id no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants