Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/access/jira/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (j *Jira) CreateIssue(ctx context.Context, reqID string, reqData RequestDat
},
},
Fields: IssueFieldsInput{
Type: &IssueType{Name: "Task"},
Type: &IssueType{Name: j.issueType},
Project: &Project{Key: j.project},
Summary: fmt.Sprintf("%s requested %s", reqData.User, strings.Join(reqData.Roles, ", ")),
Description: description,
Expand Down
1 change: 1 addition & 0 deletions integrations/access/jira/fake_jira_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ func NewFakeJira(author UserDetails, concurrency int) *FakeJira {
Fields: IssueFields{
Summary: issueInput.Fields.Summary,
Description: issueInput.Fields.Description,
Type: *issueInput.Fields.Type,
},
Properties: make(map[string]interface{}),
}
Expand Down
18 changes: 18 additions & 0 deletions integrations/access/jira/jira_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -854,3 +854,21 @@ func (s *JiraSuite) TestRace() {
})
assert.Equal(t, s.raceNumber, count)
}

// TestCustomIssueType tests that requests can use a custom issue type.
func (s *JiraSuite) TestCustomIssueType() {
t := s.T()
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
t.Cleanup(cancel)

s.appConfig.Jira.IssueType = "Story"
s.startApp()

// Test setup: we create an access request
_ = s.createAccessRequest()

// We validate that the issue was created using the Issue Type "Story"
newIssue, err := s.fakeJira.CheckNewIssue(ctx)
require.NoError(t, err)
require.Equal(t, "Story", newIssue.Fields.Type.Name)
}