Correctly filter out system roles#40545
Merged
Merged
Conversation
gzdunek
added
backport/branch/v14
no-changelog
marcoandredinis
approved these changes
Apr 15, 2024
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Can we please add some tests?
Tener
approved these changes
Apr 15, 2024
ryanclark
approved these changes
Apr 15, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
gzdunek
added a commit
that referenced
this pull request
Apr 22, 2024
* Correctly filter out system roles * Move `SkipSystemRoles` check above `SearchKeywords` check * Add tests (cherry picked from commit 22a3389)
gzdunek
added a commit
that referenced
this pull request
Apr 22, 2024
* Correctly filter out system roles * Move `SkipSystemRoles` check above `SearchKeywords` check * Add tests (cherry picked from commit 22a3389)
This was referenced Apr 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web UI's
listRoleshandler has a logic that filters out system roles.That worked fine in the past, but now we paginate the results, and filtering pages can result in inconsistent number of results on them.