SmartCard ascii variants#40287
Merged
Merged
Conversation
added 3 commits
March 29, 2024 15:30
… call Includes minor refactor to clean up the code a bit.
probakowski
approved these changes
Apr 9, 2024
zmb3
approved these changes
Apr 12, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from AntonAM
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Current hash corresponds to IronRDP branch (should be changed before merging). * Updates ScardBackend message handling code to account for ascii variants * Return a timeout when we receive a non-infinite timeout status change call Includes minor refactor to clean up the code a bit. * updates to latest IronRDP master hash
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Current hash corresponds to IronRDP branch (should be changed before merging). * Updates ScardBackend message handling code to account for ascii variants * Return a timeout when we receive a non-infinite timeout status change call Includes minor refactor to clean up the code a bit. * updates to latest IronRDP master hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
Adds handling for ascii variants of smartcard calls as well as handling for non-infinite timeouts.
A user in the community slack tested this out for me.
changelog: Adds support for the ascii variants of smartcard calls