Fix access request promotion of windows_desktop resources#40273
Merged
Conversation
lxea
commented
Apr 5, 2024
Comment on lines
+1698
to
+1700
| case types.KindWindowsDesktop: | ||
| keyPrefix = []string{windowsDesktopsPrefix} | ||
| unmarshalItemFunc = backendItemToWindowsDesktop |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is right, WindowsDesktop isnt part of/managed by the presence service, I'm not sure if that matters, but It makes the test look a little funny
r0mant
approved these changes
Apr 17, 2024
r0mant
requested review from
smallinsky
and removed request for
Joerger and
strideynet
smallinsky
approved these changes
Apr 18, 2024
This was referenced Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIx for #36577
changelog: Fix access request promotion of windows_desktop resources