Web: Add auto discover capability to EC2 enrollment#40243
Merged
Conversation
avatus
reviewed
Apr 8, 2024
Comment on lines
+250
to
+252
| .then(resp => { | ||
| return resp ?? []; | ||
| }); |
Contributor
There was a problem hiding this comment.
what would make this resp null or undefined?
Contributor
Author
There was a problem hiding this comment.
it's not guaranteed that the backend will return an empty array, as an empty array, it can come back as null/undefined
i think it's when you define something like this:
var someSlice []string
if this gets sent as is, it's undefined. i don't remember where but it bit us before, so anytime i expect an array, i just check for undefined/null
95847cf to
84fbe3e
Compare
Contributor
Author
avatus
approved these changes
Apr 10, 2024
Contributor
There was a problem hiding this comment.
Suggested change
| This may take a few minutes.. | |
| This may take a few minutes. |
or "..."?
r0mant
approved these changes
Apr 12, 2024
84fbe3e to
d1bccb3
Compare
kimlisa
added a commit
that referenced
this pull request
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #35435
New additions related to auto discover:
ec2 instsance connection endpointwith the vpc filtercreate-in-progressand poll untilcreate-completecreate-completestatusDemo
https://www.loom.com/share/4b5a6ac44c53452a9c05c946cc69ba0c
changelog: Add auto discover capability to EC2 enrollment in the web UI