Skip to content

Copy Terraform provider from teleport-plugins repo#40224

Merged
hugoShaka merged 4 commits into
masterfrom
hugo/vendor-terraform-provider
Apr 10, 2024
Merged

Copy Terraform provider from teleport-plugins repo#40224
hugoShaka merged 4 commits into
masterfrom
hugo/vendor-terraform-provider

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

This PR copies the code from the TF provider from the teleport-plugins repo (we are consolidating everything into one repo).

The changes are:

  • replace all occurrences of gravitational/teleport-plugins/terraform by gravitational/teleport/integrations/terraform
  • add a dedicated go.mod to avoid TF deps to pollute the main go mod (and add replace directives for teleport and teleport/api)
  • skip all non-OSS test when run against OSS
  • use the new AuthHelper and integration test suite to start an auth server instead of using a binaries and relying on logs to control the execution flow
  • switch the github connector in the test fixtures from gravitational to octocat as gravitational has SSO enabled and the tests were not happy with this

Tip

For reviewers: you will want to look at the integrations/terraform/tests/main_test.go file as it's the one where I wrote code. The reset of the project is essentially untouched.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@hugoShaka
Copy link
Copy Markdown
Contributor Author

make test and make gen-tfschema are passing

Copy link
Copy Markdown
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 0.35% of the lines. LGTM 😆

Copy link
Copy Markdown
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Contributor

@marcoandredinis marcoandredinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 😱

If you can please the CI, go for it 💪

Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@hugoShaka hugoShaka added terraform-provider Issues relating to the Teleport Terraform provider in the teleport-plugins repo no-changelog Indicates that a PR does not require a changelog entry labels Apr 5, 2024
@hugoShaka
Copy link
Copy Markdown
Contributor Author

hugoShaka commented Apr 9, 2024

Blocked by #40369

@hugoShaka hugoShaka force-pushed the hugo/vendor-terraform-provider branch from 36a28a0 to b1e30bc Compare April 9, 2024 23:30
@hugoShaka hugoShaka enabled auto-merge April 10, 2024 04:22
@hugoShaka hugoShaka added this pull request to the merge queue Apr 10, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@hugoShaka hugoShaka added this pull request to the merge queue Apr 10, 2024
Merged via the queue into master with commit d83cfd1 Apr 10, 2024
@hugoShaka hugoShaka deleted the hugo/vendor-terraform-provider branch April 10, 2024 05:32
hugoShaka added a commit that referenced this pull request Apr 23, 2024
* copy terraform provider

* Make dependecy checker happy + use go 1.22

* Run terraform tests in the CI, add Makefile target

* go mod tidy
github-merge-queue Bot pushed a commit that referenced this pull request Apr 23, 2024
* Copy Terraform provider from teleport-plugins repo (#40224)

* copy terraform provider

* Make dependecy checker happy + use go 1.22

* Run terraform tests in the CI, add Makefile target

* go mod tidy

* Migrate Slack access plugin tests (#38427)

* Migrate ServiceNow access plugin tests (#38413)

* Migrate ServiceNow access plugin tests

* lint

* Migrate pagerduty access plugin tests (#38412)

* Migrate opsgenie access plugin tests (#38410)

* Migrate mattermost access plugin tests (#38408)

* Migrate discord access plugin tests (#38405)

* Migrate jira access plugin tests (#38406)

* Migrate jira access plugin tests

* grant the access_request.update permission

* lint

* license

* Vendor teleport-event-handler (#40364)

* Vendor event-forwarder plugin

* fix tests + add Makefile + CI

* lint

* Fix broken test

* use a separate go.mod

* ignore event-handler in flaky tests + update go.mod

* go mod tidy

* fix TF go mod

* Fix path filtering in unit (integrations) CI (#40488)

* fix broken path filtering in workflow

* go mod tidy

* Prepare teleport access plugin enterprise test suite (#40479)

* Make AuthHelper support enterprise

* Split access OSS and Enterprise tets suites

* fix slack tests

* fix race in accesslist reminder tests

* fixup! fix race in accesslist reminder tests

* Skip flaky access plugin tests (#40525)

* Skip flaky access plugin tests

* fixup! Skip flaky access plugin tests

* Lint Terraform and Event-Handler (#40604)

* Lint Terraform and Event-Handler

* lint terraform

* add Makefile lint targets for TF and event-handler

* address feedback

* Update integrations/event-handler/Makefile

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

---------

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

* Split Terraform OSS and enterprise test suites (#40534)

* Split TF oss and TF ent tests

* Add makefile target + use eintegration

* update go mod

* Vendor plugin charts (#40373)

* vendor plugin charts

* add tests and version update

* re-generate go modules

* tolerate-ghsa

* bump helm to 3.14.3 to appease the dependency reviewer

* reduce go version to 1.21

* tidy after rebase

---------

Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/xl terraform-provider Issues relating to the Teleport Terraform provider in the teleport-plugins repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants