[v13] Wrap diag service listener with multiplexer so it can work behind PROXY enabled loadbalancer/proxy.#40140
Merged
AntonAM merged 1 commit intobranch/v13from Apr 3, 2024
Conversation
…XY enabled loadbalancer/proxy. (#39497) * Wrap diag service listener with multiplexer so it can work behind PROXY enabled loadbalancer/proxy. It accept simultaneously connections that are prepended with PROXY line or not. We also don't issue warnings about unspecified PROXY protocol mode for this listener. * Fix wording. Co-authored-by: Gus Luxton <gus@goteleport.com> * Use ExitContext instead of GracefulExitContext Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * Close diag multiplexer listener during diagnostic.shutdown event. * Refactor server.Serve() call * Move creation of muxListener outside of diagnostic.service event. * Combine declaration and usage Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Gus Luxton <gus@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
rosstimothy
approved these changes
Apr 2, 2024
espadolini
approved these changes
Apr 2, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from webvictim
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #39497 to branch/v13
Manual backport because of log->logger changes and multiplexer didn't need
SuppressUnexpectedPROXYWarningbecause of old approach to PROXY protocol.changelog: Allow diagnostic endpoints to be accessed behind a PROXY protocol enabled loadbalancer/proxy.