Include system annotations in audit event entries for access requests#40045
Merged
Include system annotations in audit event entries for access requests#40045
Conversation
capnspacehook
approved these changes
Mar 29, 2024
codingllama
approved these changes
Apr 1, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Looks good, minor comments.
r0mant
reviewed
Apr 2, 2024
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm with Alan's comments but can we have test coverage here please?
lxea
force-pushed
the
lxea/audit-log-annotations
branch
from
ce47b2e to
d6d165b
Compare
codingllama
approved these changes
Apr 2, 2024
lxea
force-pushed
the
lxea/audit-log-annotations
branch
from
d6d165b to
c6179d7
Compare
codingllama
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example access request with this change:
{ "annotations": { "hello": [ "hello" ] }, "cluster_name": "localhost", "code": "T5000I", "ei": 0, "event": "access_request.create", "expires": "2024-03-31T01:18:59.523355715Z", "id": "018e8ba6-aac2-7edd-b97b-eba3ad0bb222", "max_duration": "2024-03-31T01:18:59.523355715Z", "roles": [ "editor" ], "state": "PENDING", "time": "2024-03-29T19:18:59.552Z", "uid": "87c17476-6a64-4349-80c1-da618767723e", "user": "alex.mcgrath@goteleport.com", "user_kind": 1 }Fix for #39747
changelog: include system annotations in audit event entries for access requests