Clean up TypeScript types related to tsh daemon#40017
Merged
Conversation
ravicious
added
no-changelog
gzdunek
approved these changes
Mar 29, 2024
avatus
approved these changes
Mar 29, 2024
|
@ravicious See the table below for backport results.
|
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VnetServiceClientis nowVnetClient.TshdClient,VnetClientand everything else needed by the outside world is exported fromweb/packages/teleterm/src/services/tshd/index.ts.tshd/types.tsis deprecated in favor of importing directly fromgen-proto-tsand moving types to files centered around concepts and data structures, rather than having a dedicatedtypes.tsfile.I'll have to manually backport this as v15 doesn't know and won't know about VNet.