Add a page_size toggle to JamfInventoryEntry#39799
Merged
codingllama merged 3 commits intomasterfrom Mar 27, 2024
Merged
Conversation
ravicious
approved these changes
Mar 26, 2024
Tener
approved these changes
Mar 26, 2024
Contributor
Author
|
I'm making a custom build with the changes here ( |
Contributor
Author
|
We've confirmed with the client that adjusting the page size solves their issue, so now I'm validated that this is a toggle worth having. I'll solve the conflicts and queue for merge. Thanks for the quick reviews! |
codingllama
force-pushed
the
codingllama/jamf-pageSize
branch
from
42c96c8 to
45fc291
Compare
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Mar 27, 2024
* Add a page_size toggle to JamfInventoryEntry * Update generated protos * Add page_size to Jamf fileconf
codingllama
added a commit
that referenced
this pull request
Mar 27, 2024
* Add a page_size toggle to JamfInventoryEntry * Update generated protos * Add page_size to Jamf fileconf
codingllama
added a commit
that referenced
this pull request
Mar 27, 2024
* Add a page_size toggle to JamfInventoryEntry * Update generated protos * Add page_size to Jamf fileconf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen issues where the default page size for inventory queries is too large, causing problems in the Jamf service. This is the first part in addressing that problem - the second part comes from an e/ change.
Changelog: Reduce default Jamf inventory page size, allow custom values to be provided