Change the tctl format for database_object_import_rule resource#39764
Merged
Conversation
Prior to this change the resource wouldn't round-trip through `tctl get ... | tctl create` because of header incompatibilities. In general, all resources must be compatible with services.UnknownResource for their `tctl` storage format.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Tener
added
the
sec-internal
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Tener
changed the title
tctl format for database_object_import_rule resource.tctl format for database_object_import_rule resource
Tener
removed
the
sec-internal
Tener
changed the title
tctl format for database_object_import_rule resourcetctl format for database_object_import_rule resource
Contributor
Author
|
Gentle ping @rudream @strideynet |
Contributor
Author
|
PTAL @rudream @strideynet |
strideynet
approved these changes
Apr 3, 2024
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Apologies for late review - I got most of the way through and forgot to finish.
rudream
approved these changes
Apr 4, 2024
Tener
added a commit
that referenced
this pull request
Apr 4, 2024
…39764) * Fix incorrect expiry when using resource153ToLegacyAdapter * Change the `tctl` format for database_object_import_rule resource. Prior to this change the resource wouldn't round-trip through `tctl get ... | tctl create` because of header incompatibilities. In general, all resources must be compatible with services.UnknownResource for their `tctl` storage format. * Lint fix
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…39764) (#40203) * Fix incorrect expiry when using resource153ToLegacyAdapter * Change the `tctl` format for database_object_import_rule resource. Prior to this change the resource wouldn't round-trip through `tctl get ... | tctl create` because of header incompatibilities. In general, all resources must be compatible with services.UnknownResource for their `tctl` storage format. * Lint fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the resource wouldn't round-trip through
tctl get ... | tctl createbecause of header incompatibilities.In general, all resources must be compatible with services.UnknownResource for their
tctlstorage format. Some other new-style resources are not, and this will need further fixes.This is technically a breaking change, however there is no clear way to fix it otherwise, and the resource is very new so it is unlikely to cause widespread issues.
Changelog: Fix incorrect format for database_object_import_rule resources with non-empty expiry.