Add support for Kubernetes websocket subprotocol v5 incoming connections.#39755
Merged
Add support for Kubernetes websocket subprotocol v5 incoming connections.#39755
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
AntonAM
force-pushed
the
anton/kube-wsv5-incoming
branch
from
56c5787 to
4b87801
Compare
tigrato
approved these changes
Mar 25, 2024
lxea
approved these changes
Mar 25, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for receiving requests for new websocket streaming subprotocol v5. Kubernetes team is deprecating SPDY protocol for streaming commands (exec, attach, port forward) and adding websocket based subprotocol v5. They released it as alpha in Kubernetes version 1.29 and it will be default in 1.30. Port forwarding migration to websocket was delayed, currently alpha is planned for 1.30.
We leave using subprotocol v5 within Teleport (and to target Kubernetes clusters) to a further PR ( #39337 ) that will not be backported to v15, while this PR will be backported to versions 15 and 14, making them be able to work with kubectl using subprotocol v5.
Changelog: Add support for Kubernetes websocket streaming subprotocol v5 connections.