Add CORS headers to the tsh login callback#39696
Merged
espadolini merged 2 commits intomasterfrom Mar 22, 2024
Merged
Conversation
probakowski
approved these changes
Mar 21, 2024
rosstimothy
approved these changes
Mar 21, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from EdwardDowling
espadolini
force-pushed
the
espadolini/tsh-login-cors
branch
from
e48a2f7 to
f7ee4f3
Compare
|
@espadolini See the table below for backport results.
|
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CORS response headers for preflight requests on
/callbackduring thetsh loginSSO login flow, which might become necessary in the future since it's a requirement that has been added and removed several times to Google Chrome (most recently discussed in https://issues.chromium.org/issues/330364341).Before this PR, launching Chrome with
--enable-features=PrivateNetworkAccessForNavigationsand going throughtsh loginresults in a successfultsh loginbut a broken page in the browser; after this PR, the browser is successfully redirected to the "Login successful" page.In addition, this PR makes it so that in the future (v17) we can have the proxy POST the callback data to
tshrather than relying on a redirect.changelog: fix broken SSO login landing page on certain versions of Google Chrome