[v14] Fix ListUnifiedResources RBAC#39534
Merged
Merged
Conversation
rosstimothy
added
the
no-changelog
RBAC works slightly different with the unified resources API so that if a user requests multiple resource kinds, and is only permitted to access a subset of them, only the allowed resources are returned instead of a trace.AccessDenied error. However, the logic for this had a slight omission if the user has access to none of the requested kinds. Prior to this change, in that scenario the API would return nil, nil instead of nil, trace.AccessDenied.
rosstimothy
force-pushed
the
bot/backport-39519-branch/v14
branch
from
34b2bc6 to
f45de9d
Compare
avatus
approved these changes
Mar 18, 2024
marcoandredinis
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #39519 to branch/v14