Fix: jq has been missing in the installer scripts#39529
Closed
tunguyen9889 wants to merge 4 commits intogravitational:masterfrom
Closed
Fix: jq has been missing in the installer scripts#39529tunguyen9889 wants to merge 4 commits intogravitational:masterfrom
tunguyen9889 wants to merge 4 commits intogravitational:masterfrom
Conversation
hugoShaka
approved these changes
Mar 18, 2024
tigrato
approved these changes
Mar 19, 2024
Contributor
Author
|
Thanks @hugoShaka and @tigrato for approving this! But I'm not sure if it needs approval from maintainers before merging, as the workflow failed with code: |
r0mant
approved these changes
Mar 19, 2024
Contributor
|
Hi @tunguyen9889, Thanks for your contribution. We are currently unable to run our tests on Please and I'll get your code merged. You will retain authorship of your commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer script which was updated in #39033 has 2 issues:
jqpackage in theno automatic upgradescondition.sudo zypper --non-interactive install ${PACKAGE_LIST}line when removed the$PACKAGE_LISTvar.