[v14] Web: Require S3 fields when creating/editing AWS OIDC Integration#39513
Merged
kimlisa merged 3 commits intobranch/v14from Mar 18, 2024
Merged
[v14] Web: Require S3 fields when creating/editing AWS OIDC Integration#39513kimlisa merged 3 commits intobranch/v14from
kimlisa merged 3 commits intobranch/v14from
Conversation
…9285) * Add s3 fields to URL param * Add s3 fields to integration awsoidc type * Create S3Bucket component, utils, fixtures * Allow s3 fields to be editable * Give warning status if s3 fields are not defined * Require s3 fields when creating * Update types, story, language, address CRs
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
approved these changes
Mar 18, 2024
rudream
approved these changes
Mar 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #39285 to branch/v14
manual because of conflict with some files not existing in v14 (discover/ EKS cluster doesn't exist)
changelog: Require AWS S3 bucket fields when creating/editing AWS OIDC integration in the web UI