[v15] Implement label templates for db objects (#38630)#39496
Merged
Tener merged 1 commit intobranch/v15from Mar 20, 2024
Merged
[v15] Implement label templates for db objects (#38630)#39496Tener merged 1 commit intobranch/v15from
Tener merged 1 commit intobranch/v15from
Conversation
* Implement label templates for db objects - Expose template parsing utilities. - Interpolate label templates using `typical` library. - Validate label templates as part of import rule validation. - Refactor code to fix cyclic imports. * Use database_service_name and object_kind for label key in preset * revert changes to `lib/utils/parse/parse.go` * Reimplement splitExpression locally for import rules * Update RFD with recent changes and mark it as implemented * rename files, add test coverage, use empty spec for validation * Log template errors directly with debug logs, log total error count as info. * Update logs
github-actions
Bot
added
backport
database-access
github-actions
Bot
requested review from
greedy52,
marcoandredinis and
smallinsky
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Tener
changed the title
greedy52
approved these changes
Mar 18, 2024
marcoandredinis
approved these changes
Mar 18, 2024
Contributor
Author
|
@smallinsky PTAL |
smallinsky
approved these changes
Mar 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38630 to v15.
Manual backport due to missing RFD backport to v15.
changelog: Database object labels will now support templates.