Conversation
espadolini
approved these changes
Mar 13, 2024
rosstimothy
approved these changes
Mar 13, 2024
Joerger
deleted the
joerger/mfa-for-admin-actions-exclude-hardware-key-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Improve the security for MFA for Admin Actions when used alongside Hardware Key support.
Removes a check that allowed certificates backed by a hardware key with MFA verification to count towards Admin Actions. hardware key based mfa verification only occurs during the client connection setup and therefore should not count as a blanket MFA verification for the full length of the client connection.
Users will now be prompted for MFA for Admin Actions in addition to the initial Hardware Key Touch/PIN check, if applicable.
In the future, we can consider solutions involving accepting hardware key based MFA verification for a short duration after the connection was established (1m?), and then only requiring webauthn verification after that time elapses. This would improve the UX for the majority of Teleport client connections for admin actions, which are short lived.
Credit to Edoardo for noticing this issue 👍