Removes the entire notion of a DynamicAccessList from Teleport#39222
Merged
Removes the entire notion of a DynamicAccessList from Teleport#39222
Conversation
Insurmountable security issues were found with the notion of dynamic AccessList ownership and membership, so the entire concept is being removed. This PR removes all internal usage of the Dynamic access list concept. The corresponding protobuf updates are coming in a later PR. Changelog: Removed Dynamic AccessList
mdwn
approved these changes
Mar 12, 2024
tigrato
approved these changes
Mar 12, 2024
Contributor
tigrato
left a comment
tigrato
left a comment
There was a problem hiding this comment.
Can you update the changelog message
public-teleport-github-review-bot
Bot
removed the request for review
from capnspacehook
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
tcsc
added a commit
that referenced
this pull request
Mar 15, 2024
Manual backport of #39222 Insurmountable security issues were found with the notion of dynamic AccessList ownership and membership, so the entire concept is being removed. This PR removes all internal usage of the Dynamic access list concept. The corresponding protobuf updates are coming in a later PR. Changelog: Removed implicit AccessList membership and ownership modes. All AccessList owners and members must be explicitly specified.
tcsc
added a commit
that referenced
this pull request
Mar 18, 2024
Following on from #39222; removes and reserves the obsolete AccessList membership and ownership fields from the API protobuf messages.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Following on from #39222; removes and reserves the obsolete AccessList membership and ownership fields from the API protobuf messages.
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Following on from #39222; removes and reserves the obsolete AccessList membership and ownership fields from the API protobuf messages.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…39388) Manual backport of #39222 Insurmountable security issues were found with the notion of dynamic AccessList ownership and membership, so the entire concept is being removed. This PR removes all internal usage of the Dynamic access list concept. The corresponding protobuf updates are coming in a later PR. Changelog: Removed implicit AccessList membership and ownership modes. All AccessList owners and members must be explicitly specified.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Following on from #39222; removes and reserves the obsolete AccessList membership and ownership fields from the API protobuf messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insurmountable security issues were found with the notion of dynamic AccessList ownership and membership, so the entire concept is being removed.
This PR removes all internal usage of the Dynamic access list concept. The corresponding prot
obuf updates are coming in a later PR.
Changelog: Removed implicit AccessList membership and ownership modes. All AccessList owners and members must be explicitly specified.