Wait a bit for (*TeleportProcess).Shutdown to finish on SIGTERM#39203
Merged
espadolini merged 1 commit intomasterfrom Mar 11, 2024
Merged
Wait a bit for (*TeleportProcess).Shutdown to finish on SIGTERM#39203espadolini merged 1 commit intomasterfrom
(*TeleportProcess).Shutdown to finish on SIGTERM#39203espadolini merged 1 commit intomasterfrom
Conversation
zmb3
approved these changes
Mar 11, 2024
rosstimothy
approved these changes
Mar 11, 2024
public-teleport-github-review-bot
Bot
removed request for
GavinFrazar,
Tener and
avatus
|
@espadolini See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional grace timeout for the fast shutdown procedure in Teleport (triggered by
SIGTERMandSIGINT), waiting two seconds forShutdown()to return after the three second timeout is hit so that we can give a better shot at cleaning up things that would not otherwise get cleaned up by the termination of the process (like UNIX sockets).Closes #10075
changelog: improved clean up of system resources during a fast shutdown of Teleport