Fix kube credentials lock in separate mode#39071
Merged
Conversation
This PR fixes situations where `tsh kube credentials` fails to delete/aquire credentials lock because the proxy is empty. This happens in separate mode and in that case we should fallback to `WebProxyAddress`. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
Bot
added
size/sm
tsh
AntonAM
approved these changes
Mar 7, 2024
ryanclark
approved these changes
Mar 7, 2024
This was referenced Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes situations where
tsh kube credentialsfails to delete/aquire credentials lock because the proxy is empty.This happens in separate mode and in that case we should fallback to
WebProxyAddress.Changelog: Fix a regression where
tsh kube credentialsfails to re-login when credentials expire.