Extend EC2 joining method to other AWS regions#39045
Merged
Conversation
This PR extends the support for EC2 joining method for the following AWS regions: - ap-south-2 - p-southeast-3 - ap-southeast-4 - ca-west-1 - eu-central-2 - eu-south-2 - il-central-1 - me-central-1 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
reedloden
reviewed
Mar 6, 2024
Contributor
reedloden
left a comment
reedloden
left a comment
There was a problem hiding this comment.
Perhaps sort this alphabetically to make it easier to see if a region is missing?
Contributor
Author
done in d65cc04 |
reedloden
suggested changes
Mar 6, 2024
reedloden
approved these changes
Mar 6, 2024
Contributor
reedloden
left a comment
reedloden
left a comment
There was a problem hiding this comment.
Spot checked each one against https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/regions-certs.html (RSA 2048 tab) and confirmed they look correct. Thanks!
mdwn
approved these changes
Mar 7, 2024
strideynet
approved these changes
Mar 7, 2024
public-teleport-github-review-bot
Bot
removed request for
Joerger and
fspmarshall
This was referenced Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the support for EC2 joining method for the following AWS regions:
Changelog: Expand the EC2 joining process to include newly created AWS regions