Treat "expired certs" errors returned from RPCs as retryable on the client side#38668
Merged
Treat "expired certs" errors returned from RPCs as retryable on the client side#38668
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
gzdunek
added
the
no-changelog
codingllama
approved these changes
Feb 27, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
I appreciate you using the "guard" error instead of just matching strings for both, that is already a bit better.
Contributor
|
(Also I approved a bit quickly, please address the comments.) |
codingllama
approved these changes
Feb 27, 2024
Contributor
Author
|
Good point, @ravicious. I will merge this PR to master, the git history will be cleaner. |
gzdunek
force-pushed
the
gzdunek/handle-remote-expired-certs
branch
from
5dc6087 to
dd93596
Compare
gzdunek
requested review from
camscale,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
gzdunek
changed the base branch from
gzdunek/use-cached-remote-client
to
master
public-teleport-github-review-bot
Bot
removed request for
klizhentas and
russjones
public-teleport-github-review-bot
Bot
removed request for
camscale,
fheinecke,
r0mant,
tcsc and
zmb3
gzdunek
changed the title
gzdunek
changed the title
Contributor
|
🤖 Vercel preview here: https://docs-qrnxua97e-goteleport.vercel.app/docs/ver/preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Connect will no longer check the user cert before making an RPC, it has to be able to properly recognize "expired certs" errors that come from the server (to show a re-login dialog).
To make it work, I added an exception for the two errors
IsErrorResolvableWithRelogin. Ideally, we should just return a "returnable" error directly from the client as described by Alan, but this sounds like a big task, beyond the scope of caching clients in Connect.Depends on #38202.