Leverage the inventory control stream to report updater metrics#38654
Merged
bernardjkim merged 4 commits intomasterfrom Feb 29, 2024
Merged
Leverage the inventory control stream to report updater metrics#38654bernardjkim merged 4 commits intomasterfrom
bernardjkim merged 4 commits intomasterfrom
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
fspmarshall
approved these changes
Feb 27, 2024
zmb3
reviewed
Feb 27, 2024
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Looks good but did we lose all of our test coverage?
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
Author
|
Reusing the |
avatus
approved these changes
Feb 28, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from Joerger
|
@bernardjkim See the table below for backport results.
|
bernardjkim
added a commit
that referenced
this pull request
Mar 1, 2024
* Leverage the inventory control stream to report updater metrics * Remove periodic instance metrics * Reuse instanceMetricsPeriod
bernardjkim
added a commit
that referenced
this pull request
Mar 1, 2024
* Leverage the inventory control stream to report updater metrics * Remove periodic instance metrics * Reuse instanceMetricsPeriod
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
…) (#38832) * Leverage the inventory control stream to report updater metrics * Remove periodic instance metrics * Reuse instanceMetricsPeriod
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
…) (#38833) * Leverage the inventory control stream to report updater metrics * Remove periodic instance metrics * Reuse instanceMetricsPeriod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies how the metrics for
total_instances,enrolled_in_upgrades, andupgrader_countsare collected.The current method of iterating over the instances results in some inconsistent metrics.
Ex: At certain points, one of our Cloud tenants reports ~11000
registered_serversbut ~18000total_instances. I'm guessing this issue might be due to agents being frequently cycled and the TTL for the list of instances being a little too long.The change iterates over the inventory instead to collect the above metrics. This is the same method that is used to collect the
registered_serversmetrics.changelog: Fixes an issue with over counting of reported Teleport updater metrics