Skip to content

[v14] Give access list warning for review in CLI in more user friendly manner #38526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenGravy merged 5 commits into from
Feb 22, 2024
+4 −4
Merged

[v14] Give access list warning for review in CLI in more user friendly manner #38526

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
147ed2b
Give access list warning for review in CLI in more user friendly manner
stevenGravy Feb 21, 2024
37ba08f
updated logic and variables based on feedback
stevenGravy Feb 21, 2024
391ce3d
removed unused comment
stevenGravy Feb 21, 2024
6cb2c7b
Update output messages on access list due dates
stevenGravy Feb 21, 2024
be0c4a9
Merge branch 'branch/v14' into bot/backport-38494-branch/v14
stevenGravy Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tool/tsh/common/tsh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4368,12 +4368,12 @@ func printLoginInformation(cf *CLIConf, profile *client.ProfileStatus, profiles
if len(accessListsToReview) > 0 {
fmt.Printf("Access lists that need to be reviewed:\n")
for _, accessList := range accessListsToReview {
d := time.Until(accessList.Spec.Audit.NextAuditDate).Round(time.Minute)
var msg string
if d > 0 {
msg = fmt.Sprintf("%v left to review", d.String())
nextAuditDate := accessList.Spec.Audit.NextAuditDate.Format(time.DateOnly)
if time.Now().After(accessList.Spec.Audit.NextAuditDate) {
msg = fmt.Sprintf("review is overdue (%v)", nextAuditDate)
} else {
msg = fmt.Sprintf("review was required %v ago", (-d).String())
msg = fmt.Sprintf("review is required by %v", nextAuditDate)
}
fmt.Printf("\t%s (%v)\n", accessList.Spec.Title, msg)
}
Expand Down