Fix incorrect color of resource cards after changing the theme#38496
Merged
Fix incorrect color of resource cards after changing the theme#38496
Conversation
zmb3
approved these changes
Feb 21, 2024
avatus
approved these changes
Feb 21, 2024
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Wow TIL about double ampersand. Awesome!!
public-teleport-github-review-bot
Bot
removed request for
ravicious,
rudream and
ryanclark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38170
It looks like there is a bug (?) in
styled-componentsstarting from v5.2.0, where replacing dynamic classes work differently than before styled-components/styled-components#3678.Changing the theme adds a new class, so after going through dark -> light -> dark, we have two classes with the same names:
Using double ampersand fixed the problem. We have to backport it only to v15, in v14 we have styled components v5.1.0 which works fine.
Changelog: Fixed incorrect color of resource cards after changing the theme in Web UI and Connect.