Skip to content

Give access list warning for review in CLI in more user friendly manner#38494

Merged
stevenGravy merged 4 commits intomasterfrom
stevenGravy/accesslistreview
Feb 21, 2024
Merged

Give access list warning for review in CLI in more user friendly manner#38494
stevenGravy merged 4 commits intomasterfrom
stevenGravy/accesslistreview

Conversation

@stevenGravy
Copy link
Copy Markdown
Contributor

@stevenGravy stevenGravy commented Feb 21, 2024

fixes #38430 . Displays review date instead of hours, mins.

changelog: Displays review dates for access lists in dates, not remaining hours in tsh.

@stevenGravy stevenGravy added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry and removed no-changelog Indicates that a PR does not require a changelog entry labels Feb 21, 2024
@stevenGravy stevenGravy marked this pull request as ready for review February 21, 2024 15:15
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Feb 21, 2024
Comment thread tool/tsh/common/tsh.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Co-authored-by: Anton Miniailo <anton@goteleport.com>
Comment thread tool/tsh/common/tsh.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@stevenGravy stevenGravy added this pull request to the merge queue Feb 21, 2024
Merged via the queue into master with commit f87568b Feb 21, 2024
@stevenGravy stevenGravy deleted the stevenGravy/accesslistreview branch February 21, 2024 22:41
@public-teleport-github-review-bot
Copy link
Copy Markdown

@stevenGravy See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

identity-governance size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give access list warning for review in CLI in more user friendly manner

3 participants